Adjust priority since relaxed mode reports even IGNORED_PRIORITY
#3000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
approved these changes
May 29, 2024
ThrawnCA
approved these changes
May 30, 2024
|
Looks like a very old bug with a few of those links that could still have something to test the condition. Guess one was hitting mybatis spring boot project, and I don't recall this at all beyond my comments. The fix seems good, though. |
JuditKnoll
reviewed
Jun 13, 2024
| @@ -9,6 +9,8 @@ Currently the versioning policy of this project follows [Semantic Versioning v2. | |||
| ### Fixed | |||
| - Do not report BC_UNCONFIRMED_CAST for Java 21's type switches when the switch instruction is TABLESWITCH ([#2782](https://github.com/spotbugs/spotbugs/issues/2782)) | |||
| - Do not throw exception when inspecting empty switch statements ([#2995](https://github.com/spotbugs/spotbugs/issues/2995)) | |||
| - Adjust priority since relaxed mode reports even `IGNORED_PRIORITY` ([#2994]https://github.com/spotbugs/spotbugs/issues/2994) | |||
There was a problem hiding this comment.
It looks like there is one ( missing for the correct formatting after the ]. Can you please add it?
There was a problem hiding this comment.
Good catch @JuditKnoll
I have made #3012 to fix other errors I've made
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the priority in case is was
>= IGNORED_PRIORITYas it might be the case in "relaxed" mode.I understand that this is expected because there's a similar adjustment at:
spotbugs/spotbugs/src/main/java/edu/umd/cs/findbugs/ProjectStats.java
Line 277 in 861f432
Not sure how to reproduce the problem and this seem fairly straightforward so I did not add a tautological test, let me know if you think this is required