Fix for FindFloatEquality same field test #2843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazendaz
approved these changes
Jan 27, 2024
|
fixes #1097 |
PatrikScully
pushed a commit
to PatrikScully/spotbugs
that referenced
this pull request
Jun 14, 2024
* test: reproducer for issue spotbugs#1097 * fix: handle the case when items aren't field in FindFloatEquality Fixes spotbugs#1097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isSameField()method was changed in 84859d1 and the case when both arguments aren't fields was changed.Reverted the change to fix
FE_FLOATING_POINT_EQUALITY