fix: Dockerfile #2427
Merged
fix: Dockerfile #2427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@claude is this ok |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several Dockerfile build issues including incorrect file copying, missing workdir setup, and redundant uv sync operations. The changes streamline the build process and ensure proper directory structure for the spotDL Docker container.
Key changes:
- Establishes proper working directory structure with
/appfor build and/musicfor downloads - Replaces selective file copying with full repository copy to avoid missing dependencies
- Eliminates redundant uv sync execution and removes unnecessary ADD command
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Silverarmor
approved these changes
Aug 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fixed Dockerfile build issues and cleaned up Dockerfile
Description
The Dockerfile does contain some issues:
The above issues are addressed as follows:
The Workdir remains /music, but it must be mounted as volume.
Further suggested changes
Make the default entrypoint command run the web interface fur better use without external commands in docker context?
Related Issue
closes #2300
closes #2422 (as the uv sync bug persisted for spotdl installation)
How Has This Been Tested?
Tested on RPI4, Ubuntu Sever 24.04
Types of Changes
Checklist