Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 9 commits
- 7 files changed
- 2 contributors
Commits on Aug 13, 2025
-
As our dependencies yt-dlp, ytmusicapi no longer support py3.9, spotDL also will drop support. yt-dlp/yt-dlp#13858
-
-
-
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
-
Fix azlyrics logic, and disable it temporarily (#2442)
# Title <!--- Provide a general summary of your changes in the Title above --> Fix azlyrics logic, and disable it temporarily ## Description <!--- Describe your changes in detail --> AZlyrics logic error causing endless loop is resolved. Also the API has been killed, so disable AZlyrics lyrics provider for now, and also include a warning msg to users with it in their default config. ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> #2439 and subsequent #2441 ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> logic error in v4.3.0, where the counter is not incremented on line 62-63 leads to an endless loop. https://github.com/spotDL/spotify-downloader/blob/5266ddb85fd182a5b357b553fd0ddec9eb0f0cd7/spotdl/providers/lyrics/azlyrics.py#L57-L67 ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> as usual ## Types of Changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project - [x] My change requires a change to the documentation - [x] I have updated the documentation accordingly - [x] I have read the [CONTRIBUTING](/docs/CONTRIBUTING.md) document - [ ] I have added tests to cover my changes - [ ] All new and existing tests passed
-
-
-
1. Drop support for Python v3.9 due to upstream dependency requirements 2. Fix AZlyrics logic error, and disable it with warning to users.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.3.1...v4.4.0