Avoid import error on flake8-import-order 0.17 version #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ipdae
commented
Feb 12, 2018
longfin
reviewed
Feb 12, 2018
setup.py
Outdated
| @@ -23,7 +23,7 @@ def readme(): | |||
| maintainer_email='dev' '@' 'spoqa.com', | |||
| license='GPLv3 or later', | |||
| py_modules=['flake8_import_order_spoqa'], | |||
| install_requires=['flake8-import-order >= 0.16'], | |||
| install_requires=['flake8-import-order <= 0.16'], | |||
kanghyojun
reviewed
Feb 12, 2018
setup.py
Outdated
| @@ -23,7 +23,7 @@ def readme(): | |||
| maintainer_email='dev' '@' 'spoqa.com', | |||
| license='GPLv3 or later', | |||
| py_modules=['flake8_import_order_spoqa'], | |||
| install_requires=['flake8-import-order >= 0.16'], | |||
| install_requires=['flake8-import-order <= 0.16'], | |||
There was a problem hiding this comment.
Would it better to fix the version of flake8-import-order to 0.16? And write some "FIXME" comment about why the version of flake8-import-order is fixed.
And I think it would be nice to fix flake8-import-order-spoqa works on the newer version of flake8-import-order.
kanghyojun
approved these changes
Feb 12, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.