Skip to content

Bash Autocompletion Generator #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2015
Merged

Bash Autocompletion Generator #69

merged 2 commits into from
Apr 11, 2015

Conversation

eparis
Copy link
Collaborator

@eparis eparis commented Mar 16, 2015

That's right. A golang program the writes a bash program!

@eparis
Copy link
Collaborator Author

eparis commented Mar 16, 2015

Requires spf13/pflag#8 before this will build

@eparis eparis force-pushed the command-annotations branch 4 times, most recently from 94e3bc2 to 9d6aada Compare March 17, 2015 23:53
eparis added a commit to eparis/kubernetes that referenced this pull request Mar 18, 2015
@eparis
update bash auto-completion code
77a74e8 
This autocompletion code was developed using:

spf13/cobra#69

Once that actually lands, we can autogenerate and make sure it never
gets out of date!
@eparis eparis mentioned this pull request Mar 18, 2015
Merged
@eparis eparis force-pushed the command-annotations branch from 9d6aada to a3cd8ac Compare March 18, 2015 18:32
@eparis eparis mentioned this pull request Mar 27, 2015
Closed
@eparis eparis force-pushed the command-annotations branch from a3cd8ac to fb50344 Compare April 6, 2015 23:35
@eparis
Copy link
Collaborator Author

eparis commented Apr 6, 2015

I pulled out annotations and hard coded a new "ValidArgs" field. We don't really validate them, but we certainly could...

@eparis
Copy link
Collaborator Author

eparis commented Apr 6, 2015

An example of what this can do:

https://github.com/eparis/kubernetes/blob/931044be011e0bd910dcaa7ccbcceb2363195582/contrib/completions/bash/kubectl

@fabianofranz
Copy link
Contributor

@eparis Add README docs about how to use it.

eparis added 2 commits April 7, 2015 20:13
@eparis
Add bash autocompletion generator
9b2e682 
Given a (potentially annotated) cobra command you can generate a bash
completion script.
@eparis
add a helper to annotate a flag as 'required' by a command
a068307
@eparis eparis force-pushed the command-annotations branch from fb50344 to a068307 Compare April 8, 2015 00:35
@eparis
Copy link
Collaborator Author

eparis commented Apr 8, 2015

Now with 55% more README and 32% more tests!

@anthonyfok anthonyfok added the kind/feature A feature request for cobra; new or enhanced behavior label Apr 10, 2015
@fabianofranz
Copy link
Contributor

Very nice! I could think of a better integration of ValidArgs (auto validation of the number of args, receive pointers the same way flags do, etc); but those could be enhancements. Looks good for now.

eparis added a commit that referenced this pull request Apr 11, 2015
@eparis
Merge pull request #69 from eparis/command-annotations
c746d30 
Bash Autocompletion Generator
@eparis eparis merged commit c746d30 into spf13:master Apr 11, 2015
@anthonyfok anthonyfok mentioned this pull request May 12, 2015
Closed
@mikedanese mikedanese mentioned this pull request May 20, 2015
Closed
@eparis eparis deleted the command-annotations branch August 12, 2015 16:31
@krook krook mentioned this pull request Jul 31, 2017
Closed
@umarcor umarcor mentioned this pull request Mar 27, 2022
Merged
@marckhouzam marckhouzam mentioned this pull request Mar 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/feature A feature request for cobra; new or enhanced behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eparis @fabianofranz @anthonyfok