Skip to content

Get MINGW64 action running #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Get MINGW64 action running #1365

wants to merge 3 commits into from

Conversation

bridgetbarnes
Copy link

The gets need to be before golangci-lint is fetched, so move them earlier to prevent the action from failing because of missing dependancies

@github-actions github-actions bot added the admin For general admin tasks to be done usualy by maintainers label Mar 10, 2021
@umarcor umarcor mentioned this pull request Mar 12, 2021
Merged
@umarcor
Copy link
Contributor

umarcor commented Mar 12, 2021

@bridgetbarnes thanks for having a look at this! Unfortunately, using get is not what we want here. get might/will modify the go.mod, which describes the dependencies of cobra. However, richgo and gox are not dependencies of cobra, but of the testing plumbing. See "No automatic changes to go.mod and go.sum" and "Installing an executable at a specific version" in https://blog.golang.org/go116-module-changes. See also #1366.

@bridgetbarnes
Copy link
Author

Oh awesome! Thanks so much for explaining, and for fixing it in your PR! Closing this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
admin For general admin tasks to be done usualy by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bridgetbarnes @umarcor