string float act like float when converted to int* #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: cast_test.go modified: caste.go
andig
reviewed
Jan 15, 2024
| @@ -1496,3 +1496,29 @@ func trimZeroDecimal(s string) string { | |||
| } | |||
| return s | |||
| } | |||
|
|
|||
| func truncateDecimals(s string) string { | |||
There was a problem hiding this comment.
Looks like this function could use a test?
There was a problem hiding this comment.
Alright, I have added it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#204 #172
built in:
cast.ToInt64E(float64(8.2)) => 8
previously:
cast.ToInt64E(string("8.2")) => unable to cast "8.2" of type string to int64
more expected:
cast.ToInt64E(string("8.2")) => 8
If you agree with my thoughts or have a better understanding, feel free to leave a comment for discussion.