Skip to content

Add more integer to boolean conversions #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2023
Merged

Add more integer to boolean conversions #153

merged 1 commit into from
Feb 5, 2023

Conversation

yveshield
Copy link
Contributor

@yveshield yveshield commented Aug 16, 2022 •
edited by sagikazarmark
Loading

Signed-off-by: Yveshield yveshield@gmail.com

If int type can be converted to bool type, why can't int8? and int16, etc.

Fixes #98
Fixes #134
Fixes #135
Fixes #137

@yveshield yveshield force-pushed the more-int-to-bool branch 3 times, most recently from a483b8a to 43e7646 Compare September 3, 2022 05:17
@yveshield
Add more integer to boolean conversions
557a6a2 
Signed-off-by: Yveshield <yveshield@gmail.com>
sagikazarmark
sagikazarmark approved these changes Feb 5, 2023
View reviewed changes
Copy link
Collaborator

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sagikazarmark sagikazarmark merged commit ba0a5b6 into spf13:master Feb 5, 2023
@andig andig mentioned this pull request May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark sagikazarmark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return error result when transform digital type (except int) to bool FeatureRequest: ToBool add int* support cast.ToBool return wrong value for int
2 participants
@yveshield @sagikazarmark