Add cases to support casting from json.Number values. #61
Conversation
|
|
|
Hi @bep ! Could you please merge this PR? |
There was a problem hiding this comment.
Instead of doing this for json.Number (which is both limiting, and it add a package dependency -- if you run GopherJS you might care about that, but that is not my main argument).
Instead I would suggest you add some internal interfaces with Int64() and check for those interface types in the case switches.
| if err == nil { | ||
| return float32(v), nil | ||
| } | ||
| return 0, fmt.Errorf("unable to cast %#v of type %T to float32", i, i) |
There was a problem hiding this comment.
I would suspect that a "fallthrough" here would have the same effect (and be shorter).
There was a problem hiding this comment.
https://github.com/golang/go/wiki/Switch#fall-through
Note: fallthrough does not work in type switch.
|
@yanmhlv @ottodashadow can this be closed or do you plan to work on this? |
|
@bep ok, I'll fix it in my own PR |
No description provided.