fix: Fix libsecp256k1 loader on FreeBSD #8320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeBSD installs libsecp256k1 as: ``` /usr/local/lib/libsecp256k1.so.2.0.1 /usr/local/lib/libsecp256k1.so -> libsecp256k1.so.2.0.1 /usr/local/lib/libsecp256k1.so.2 -> libsecp256k1.so.2.0.1 ```
|
LGTM |
|
I think this might be the wrong approach. I am not sure the root cause has anything to do with freebsd. |
SomberNight
added a commit
that referenced
this pull request
Apr 21, 2023
this replaces #8320 see https://github.com/bitcoin-core/secp256k1/blob/f6bef03c0a2c826227708dbeaecf1dbc702a2567/CHANGELOG.md I am not yet sure how this will look like going forward, but unless there will be lots of libsecp256k1 releases with ~invisible harmless ABI changes, I think conceptually this is the right approach.
|
pushed a follow-up in 784fc27 |
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
Apr 21, 2023
We don't actually need the development headers, instead using this as a hack to be agnostic to the version scheme and pull in the latest. related: spesmilo#8185 spesmilo#8320 spesmilo#8328 (comment) debian 11 (stable) only has libsecp256k1-0 debian 12 (testing) atm only has libsecp256k1-1 ubuntu 23.04 only has libsecp256k1-1 I expect libsecp256k1-2 might soon get packaged too, now that upstream secp released v0.3.0. So what do tell users to install? well, turns out most distros have libsecp256k1-dev, which just pull in the latest secp. Caveat: if there is a new secp release that actually gets packaged on a distro before we can react, then this new instruction will not work.
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
Apr 21, 2023
We don't actually need the development headers, instead using this as a hack to be agnostic to the version scheme and pull in the latest. related: spesmilo#8185 spesmilo#8320 spesmilo#8328 (comment) debian 11 (stable) only has libsecp256k1-0 debian 12 (testing) atm only has libsecp256k1-1 ubuntu 23.04 only has libsecp256k1-1 I expect libsecp256k1-2 might soon get packaged too, now that upstream secp released v0.3.0. So what do we tell users to install? well, turns out most distros have libsecp256k1-dev, which just pulls in the latest secp. Caveat: if there is a new secp release that actually gets packaged on a distro before we can react, then this new instruction will not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD installs libsecp256k1 as: