remove "from addresses" #4405
Merged
remove "from addresses" #4405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
605917c to
a0ba5a7
Compare
SomberNight
added a commit
that referenced
this pull request
Jun 13, 2018
SomberNight
added a commit
that referenced
this pull request
Jun 15, 2018
rt121212121
reviewed
Apr 6, 2019
| # give v to txi that spends me | ||
| next_tx = self.spent_outpoints[tx_hash].get(n) | ||
| if next_tx is not None: | ||
| dd = self.txi.get(next_tx, {}) |
electrum-user-account
added a commit
to electrum-user-account/electrum
that referenced
this pull request
Jan 31, 2020
The serialized transaction format was changed here spesmilo#4405 The change occurred in Electrum 3.2.0. ( before: https://github.com/spesmilo/electrum/blob/624fa4769d9f02fa71696b3d69030ae114ccf573/lib/transaction.py#L891 after: https://github.com/spesmilo/electrum/blob/0119ab9ee1c4b07255442c7c91a7119ca989b64c/lib/transaction.py#L1013 ) I ran into this myself, here: spesmilo#5924 Personally I believe that users should be notified of breaking changes. Users should not have to make educated guesses, ask online, or be python programmers in order to be able to tell whats going on / why doesn't it work. If you don't like this verbiage (for example, if you think that the user should be instructed to always use the exact same electrum version when importing / exporting) Then an alternative verbiage would be appropriate, such as "Always use the exact same Electrum version to import any exported transactions." If that doesn't fit there the label can be moved. Or it could be `'Electrum ' + current_electrum_version + ' required to import.'` Or Something. Point is that there should be some indication of this fact of life to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_mineinput addresses are shownis_minerestriction" fromwallet.spent_outpointswallet.spent_outpointsis now persisted in the wallet file; there is a corresponding v17 version upgrade. wallet files are expected to become ~10% larger on disk