Skip to content

Conversation

bact
Copy link
Collaborator

@bact bact commented Apr 28, 2025

  • Update JAR name in command line examples to version 2.0.0
  • Fix few Markdown issues
  • Add Javadoc link

- Update JAR name in command line examples to version 2.0.0
- Fix few Markdown issues
- Add Javadoc link
@bact bact added the documentation Improvements or additions to documentation label Apr 28, 2025
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I miss this every time, I'll add a step in the release checklist to update the README on release

@goneall goneall merged commit 742af94 into spdx:master Apr 28, 2025
1 check passed
@goneall
Copy link
Member

goneall commented Apr 28, 2025

LGTM - I miss this every time, I'll add a step in the release checklist to update the README on release

It looks like it is already in the README file - I just need to make sure I follow all the steps.

@bact bact deleted the update-version-in-cmd-examples branch April 28, 2025 23:52
@bact
Copy link
Collaborator Author

bact commented Apr 28, 2025

I think it's fine to have the version in examples a bit out of date (not the latest).

But in this particular case, since we just have a new major release/stable version, I just feel that it will give a better impression to developers if we can use the release/stable version in the examples (instead of RC).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants