Skip to content

Use URI.create().tourl("") instead of the deprecated url("") constructor #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2025
Merged

Use URI.create().tourl("") instead of the deprecated url("") constructor #197

merged 2 commits into from
Apr 19, 2025

Conversation

bact
Copy link
Collaborator

@bact bact commented Apr 17, 2025 •
edited
Loading

  • "new url("")" is deprecated in Java 20
  • Use recommended URI.create().tourl("") (available since Java 1.4)

@bact
Use URI.created().tourl("") instead of new url("")
ea9cd8c 
- URI.created().tourl("") is available since Java 1.4
- new url("") (constructor) is deprecated in Java 20

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added the test Unit test, code coverage, test case label Apr 17, 2025
@bact bact changed the title Use URI.created().tourl("") instead of thhe deprecated url("") constructor Use URI.create().tourl("") instead of the deprecated url("") constructor Apr 17, 2025
goneall
goneall approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bact bact merged commit c391d5c into spdx:master Apr 19, 2025
1 check passed
@bact bact deleted the add-schema-ver-check branch April 19, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

Assignees
No one assigned
Labels
test Unit test, code coverage, test case
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bact @goneall