Skip to content

Conversation

bact
Copy link
Collaborator

@bact bact commented Apr 16, 2025

This PR does two things:

  1. Update the content of resources/spdx-schema-v3.0.1.json (download from https://spdx.org/schema/3.0.1/spdx-json-schema.json)
  2. Add a unit test to compare the content of the latest version of local JSON schema file with its remote counterpart

To resolve, the schema part, of #183

bact added 2 commits April 16, 2025 10:59
Check content of local schema file with the remote location.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added the enhancement New feature or request label Apr 16, 2025
@bact
Copy link
Collaborator Author

bact commented Apr 16, 2025

PR check failed because of an indirect dependency is not found in Maven Central.
A temporary fix is in PR #196 / or wait until next release of spdx-java-v3jsonld-store.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition - thanks @bact

@goneall goneall merged commit abdae87 into spdx:master Apr 17, 2025
1 check failed
@bact bact added the test Unit test, code coverage, test case label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Unit test, code coverage, test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants