Skip to content

Conversation

bact
Copy link
Collaborator

@bact bact commented Apr 16, 2025

Add version info for maven-shade-plugin in pom.xml to fix this warning:

[WARNING] Some problems were encountered while building the effective model for org.spdx:tools-java:jar:2.0.0-RC3-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-shade-plugin is missing. @ line 285, column 15
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.

Version 3.4.1 is the latest version that can still compile successfully with current codebase.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added the dependencies Pull requests that update a dependency file label Apr 16, 2025
@bact
Copy link
Collaborator Author

bact commented Apr 16, 2025

PR check failed because of an indirect dependency is not found in Maven Central.
A temporary fix is in PR #196 / or wait until next release of spdx-java-v3jsonld-store.

@goneall goneall merged commit 46081d6 into spdx:master Apr 17, 2025
1 check failed
@bact bact deleted the add-maven-shade-version branch April 17, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants