feat: Refactor CMake project #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to have this one ready for the CECAM meeting so I can use it as an example project |
2924ef6 to
d8e00c7
Compare
bc75a48 to
1664ec6
Compare
LecrisUT
commented
Jan 19, 2024
9cbfe48 to
3408d60
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #397 +/- ##
============================================
+ Coverage 71.69% 83.59% +11.89%
============================================
Files 51 24 -27
Lines 9483 8119 -1364
Branches 1754 1694 -60
============================================
- Hits 6799 6787 -12
+ Misses 2683 1332 -1351
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jan 25, 2024
Closed
faae181 to
3b10b29
Compare
e3c555f to
e27399e
Compare
LecrisUT
commented
Jan 25, 2024
e86aaad to
d9021b6
Compare
1 task
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
We are not actually using any of these afaik Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Use `cmake.define` instead of `cmake.args`. The latter cannot be overriden via CLI Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <git@lecris.dev> Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
9e6e56d to
922c607
Compare
|
testing-farm:fedora-39-aarch64 seems to be failed 🤔 |
|
Thnx, didn't notice it. It seemed it was just a network issue. I have just restarted it. |
lan496
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main things here:
Depends on #362 (maybe also #271)
Closes #363, #353