Skip to content

Drop ASE Atoms-style input #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2024
Merged

Drop ASE Atoms-style input #386

merged 1 commit into from
Jan 2, 2024
+8 −43

Conversation

lan496
Copy link
Member

@lan496 lan496 commented Jan 2, 2024 •
edited
Loading

Closes #385

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04d097d) 83.84% compared to head (a5a94e2) 83.84%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #386   +/-   ##
========================================
  Coverage    83.84%   83.84%           
========================================
  Files           24       24           
  Lines         8172     8172           
========================================
  Hits          6852     6852           
  Misses        1320     1320
Flag Coverage Δ
c_api 77.57% <ø> (ø)
fortran_api 56.21% <ø> (ø)
python_api 80.48% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lan496 lan496 requested a review from atztogo January 2, 2024 01:46
atztogo
atztogo approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@atztogo atztogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lan496!

@lan496 lan496 merged commit 1fd01be into spglib:develop Jan 2, 2024
@LecrisUT LecrisUT added this to the 2.3 milestone Jan 25, 2024
@chenrui333 chenrui333 mentioned this pull request Jan 28, 2024
Merged
@samwaseda samwaseda mentioned this pull request Jan 30, 2024
Merged
This was referenced Feb 5, 2024
Closed
Closed
@atztogo atztogo mentioned this pull request Jun 13, 2024
Closed
@akvatol akvatol mentioned this pull request Aug 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atztogo atztogo atztogo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

Drop ASE Atoms-like input for Python interface
4 participants
@lan496 @codecov-commenter @atztogo @LecrisUT