Skip to content

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Dec 8, 2023

This PR bumps the versions to indicate for the user where the development of the new release started. Maybe should revisit #273 at some point. Python upstream supports it now.

Also I noticed there were no metadata classifiers, so I've added them here for the new release

Closes: #373
Depends on: #375

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT requested a review from lan496 December 8, 2023 11:11
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06ad3e3) 83.80% compared to head (4640af8) 83.80%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #376   +/-   ##
========================================
  Coverage    83.80%   83.80%           
========================================
  Files           24       24           
  Lines         8167     8167           
========================================
  Hits          6844     6844           
  Misses        1323     1323           
Flag Coverage Δ
c_api 77.18% <ø> (ø)
fortran_api 56.19% <ø> (ø)
python_api 80.47% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I agree the next release will change the minor version.

@lan496 lan496 enabled auto-merge December 9, 2023 11:08
@lan496 lan496 merged commit 8f7f01c into spglib:develop Dec 9, 2023
@LecrisUT LecrisUT deleted the post-release branch January 25, 2024 10:42
@lan496 lan496 added this to the 2.3 milestone Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Drop Python 3.7
3 participants