Skip to content

Conversation

atztogo
Copy link
Collaborator

@atztogo atztogo commented Nov 18, 2023

Following #354, I put links to the definition page from the variable page. I also made expressions in these pages roughly consistent for basis vectors, point coordinates, and symmetry operation.

@atztogo atztogo requested a review from lan496 November 18, 2023 10:25
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b02dedb) 83.80% compared to head (d1103a1) 83.80%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #369   +/-   ##
========================================
  Coverage    83.80%   83.80%           
========================================
  Files           24       24           
  Lines         8167     8167           
========================================
  Hits          6844     6844           
  Misses        1323     1323           
Flag Coverage Δ
c_api 77.18% <ø> (ø)
fortran_api 56.19% <ø> (ø)
python_api 80.47% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LecrisUT LecrisUT merged commit 39a9556 into spglib:develop Nov 21, 2023
@atztogo atztogo deleted the doc-update branch November 22, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants