Skip to content

Check pointer to magnetic dataset before free #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2023
Merged

Check pointer to magnetic dataset before free #349

merged 4 commits into from
Oct 31, 2023

Conversation

lan496
Copy link
Member

@lan496 lan496 commented Oct 28, 2023

Fixes #348

@lan496 lan496 requested a review from LecrisUT October 28, 2023 01:42
@lan496 lan496 mentioned this pull request Oct 28, 2023
Closed
2 tasks
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf0b4b7) 83.55% compared to head (cc63cb3) 83.68%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #349      +/-   ##
===========================================
+ Coverage    83.55%   83.68%   +0.12%     
===========================================
  Files           24       24              
  Lines         8154     8144      -10     
===========================================
+ Hits          6813     6815       +2     
+ Misses        1341     1329      -12
Flag Coverage Δ
c_api 76.45% <100.00%> (+0.02%) ⬆️
fortran_api 56.29% <0.00%> (ø)
python_api 80.54% <0.00%> (+0.12%) ⬆️
unit_tests 1.24% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/spglib.c 72.48% <100.00%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LecrisUT
LecrisUT requested changes Oct 30, 2023
View reviewed changes
LecrisUT
LecrisUT requested changes Oct 31, 2023
View reviewed changes
@lan496 lan496 requested a review from LecrisUT October 31, 2023 12:41
@lan496 lan496 merged commit a0263dd into spglib:develop Oct 31, 2023
@lan496 lan496 deleted the fix-issue-348 branch October 31, 2023 22:30
@lan496 lan496 mentioned this pull request Oct 31, 2023
Closed
@Porkepix Porkepix mentioned this pull request Dec 8, 2023
Merged
@LecrisUT LecrisUT added this to the 2.2 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LecrisUT LecrisUT LecrisUT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

get_magnetic_symmetry_dataset seg fault
3 participants
@lan496 @codecov-commenter @LecrisUT