-
Notifications
You must be signed in to change notification settings - Fork 116
Add "Julia interface" to interface.md #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM @atztogo @lan496 thoughts? On my side I only have a few CI questions outside of this PR:
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #340 +/- ##
========================================
Coverage 83.53% 83.53%
========================================
Files 24 24
Lines 8157 8157
========================================
Hits 6814 6814
Misses 1343 1343
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm not the expert but I will try to answer these questions:
Julia has a mechanism called "artifacts", which ships binary executables or libraries. In the building package of that artifact (in this case, the package But To keep track of the latest release of However, I do have problems building the v2.1.0 version of
I'm not sure about what you mean here. I currently put all tests here. Most of the CI builds are successful. Here is one example (The errors are intentional since the package only works on Julia v1.6+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've responded in the julia PR about the packaging. But otherwise it seems the updates are opened manually? It is preferable that there is some automation for the release also for
I mean, can you make a github workflow that builds |
Thanks @singularitti. It is very nice to inform the existence of the Julia interface from the documentation officially. |
Thank you very much! I'll look into the |
Sorry, would you mind changing the title to "Rust, Fortran, Julia, and Ruby interfaces"? I forgot to update that. |
I think we'll refactor that to something else to include packaging as well |
Cool! Please inform me if there's anything I can help. |
Greetings,
As a user of spglib and an active contributor within the Julia community, I have successfully ported the C-API to Julia, which can be accessed here. However, the magnetic interface is yet to be implemented and I would greatly appreciate any assistance in this regard.
The Spglib.jl is already being utilized by some individuals, and it is my aspiration to further promote both spglib and Spglib.jl, thereby expanding their user base.