Add Fortran interface and Fortran interface tests #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added spg_get_magnetic_spacegroup_type Fortran interface * Added spg_get_magnetic_spacegroup_type Fortran interface test * Added spg_get_spacegroup_type Fortran interface test
|
Can you add - repo: https://github.com/pseewald/fprettify
rev: v0.3.7
hooks:
- id: fprettify
args: [ '-i', '4' ] |
I made it. Thanks. This is helpful. |
LecrisUT
requested changes
Sep 25, 2023
|
@LecrisUT, do you think I can merge this PR though two tests fail? |
|
Yes, but wait for me to review this |
LecrisUT
requested changes
Sep 26, 2023
test/functional/fortran/test_fortran_spg_get_magnetic_spacegroup_type.F90
Outdated
Show resolved
Hide resolved
test/functional/fortran/test_fortran_spg_get_spacegroup_type.F90
Outdated
Show resolved
Hide resolved
test/functional/fortran/test_fortran_spg_get_magnetic_spacegroup_type.F90
Show resolved
Hide resolved
test/functional/fortran/test_fortran_spg_get_magnetic_spacegroup_type.F90
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #337 +/- ##
===========================================
+ Coverage 82.99% 83.53% +0.53%
===========================================
Files 24 24
Lines 8140 8157 +17
===========================================
+ Hits 6756 6814 +58
+ Misses 1384 1343 -41
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
LecrisUT
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Fortran interface and Fortran interface tests
spg_get_magnetic_spacegroup_typeFortran interfacespg_get_magnetic_spacegroup_typeFortran interface testspg_get_spacegroup_typeFortran interface testFormatted
spglib_f08.F90byfprettify -i 4 spglib_f08.F90.