Skip to content

Conversation

atztogo
Copy link
Collaborator

@atztogo atztogo commented Sep 20, 2023

A fresh PR for the same purpose but instead of #292.

I also added tests for spg_get_dataset in Fortran.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Attention: Patch coverage is 78.08219% with 16 lines in your changes missing coverage. Please review.

Project coverage is 82.99%. Comparing base (04d012d) to head (9260376).
Report is 314 commits behind head on develop.

Files with missing lines Patch % Lines
fortran/spglib_f08.F90 78.08% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #333      +/-   ##
===========================================
- Coverage    83.60%   82.99%   -0.61%     
===========================================
  Files           23       24       +1     
  Lines         7942     8140     +198     
===========================================
+ Hits          6640     6756     +116     
- Misses        1302     1384      +82     
Flag Coverage Δ
c_api 76.10% <ø> (ø)
fortran_api 53.45% <78.08%> (+16.63%) ⬆️
python_api 80.42% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atztogo atztogo merged commit 9f2d02d into spglib:develop Sep 20, 2023
@atztogo atztogo deleted the magdataset branch September 20, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants