Skip to content

Fix: build wheel workflow #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 8, 2023
Merged

Fix: build wheel workflow #321

merged 4 commits into from
Sep 8, 2023

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Aug 23, 2023 •
edited
Loading

Either the emulation is needed in order to build for linux-arm or we can try CircleCI.

Experimenting with CircleCI for a while in https://github.com/LecrisUT/spglib/actions/workflows/ci.yaml

Will come back to CircleCI and CirrusCI in a later PR.

@LecrisUT LecrisUT force-pushed the fix/cibw branch 12 times, most recently from 3a6c9e4 to fcb2cce Compare August 23, 2023 14:13
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (6f45a2b) 83.60% compared to head (20a636d) 83.60%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #321   +/-   ##
========================================
  Coverage    83.60%   83.60%           
========================================
  Files           23       23           
  Lines         7942     7942           
========================================
  Hits          6640     6640           
  Misses        1302     1302
Flag Coverage Δ
c_api 76.10% <ø> (ø)
fortran_api 36.82% <ø> (ø)
python_api 80.42% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT LecrisUT force-pushed the fix/cibw branch 10 times, most recently from 69d100a to c82cb70 Compare August 25, 2023 22:16
@LecrisUT LecrisUT mentioned this pull request Sep 4, 2023
Closed
4 tasks
@LecrisUT LecrisUT marked this pull request as ready for review September 4, 2023 12:20
@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Sep 4, 2023 •
edited
Loading

@lan496 This one can be merged, but after merging, trigger a CI workflow manually with the default settings and Upload wheel as an artifact. If that one works, and you see al of the x86_64, aarch64 wheels, it should be good to do another rc

Here is a run on my fork for reference if you want to wait for it before merging.

@lan496
Copy link
Member

lan496 commented Sep 4, 2023

Artifacts do not seem to be uploaded https://github.com/spglib/spglib/actions/runs/6073266832?pr=321.
What happened the CI: CI / build-wheel / Build source distribution?

@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Sep 4, 2023 •
edited
Loading

There seems to be a bug with running python3 -m build the symlink for 'spglib-2.1.0rc3/test/package/FetchContent/c/main.c' points to 'spglib-2.1.0rc3/test/package/main.c', but python3 -m build is reporting to point to /main.c. That is a weird bug on upstream

Yes, it is a bug: python/cpython#107846. Seems we have to wait for: python/cpython#107845

@LecrisUT LecrisUT force-pushed the fix/cibw branch 2 times, most recently from c9b38e0 to 226a772 Compare September 5, 2023 09:13
@LecrisUT
Add linux emulation
4432fad 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Specify python versions
5b3ec64 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Bump actions/checkout to v4
ad8eefa 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Add CI job reporting
21c888d 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT requested a review from lan496 September 7, 2023 00:45
@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Sep 7, 2023 •
edited
Loading

Can check the run here, specifically check the artifacts have all wheels

@lan496
Copy link
Member

lan496 commented Sep 7, 2023

It seems actions/upload-artifacts was skipped 🤔
https://github.com/LecrisUT/spglib/actions/runs/6104366753/job/16566506128
image

@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Sep 7, 2023

Oh, right, I forgot to include the flag to upload this one should have it.

lan496
lan496 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@lan496 lan496 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've checked the artifact is uploaded.

@lan496 lan496 merged commit acb0f2e into spglib:develop Sep 8, 2023
@LecrisUT LecrisUT deleted the fix/cibw branch September 11, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lan496 lan496 lan496 approved these changes

Assignees

@lan496 lan496

Labels
None yet
Projects
Spglib developers' kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LecrisUT @codecov-commenter @lan496