Skip to content

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Aug 14, 2023

  • Fix Fortran module install location
  • Added examples to Fedora CI
  • Added packaging tests to Fedora CI

Closes #313

@LecrisUT LecrisUT mentioned this pull request Aug 14, 2023
4 tasks
@LecrisUT LecrisUT added the bug label Aug 14, 2023
@LecrisUT LecrisUT requested review from atztogo and lan496 August 14, 2023 17:25
@lan496 lan496 removed their request for review August 16, 2023 11:21
@lan496
Copy link
Member

lan496 commented Aug 16, 2023

Thanks! I will defer to atztogo on this PR.

@atztogo
Copy link
Collaborator

atztogo commented Aug 16, 2023

@LecrisUT, could you tell me what I can review? I have really no idea about rpm.

@LecrisUT
Copy link
Collaborator Author

Basically only a4190b7. On the fortran side it just changes the installation location from /usr/include/spglib_f08.mod to /usr/include/spglib/gcc-13/spglib_f08.mod so that you can install the intel, flang variants etc.

The additional tmt packaging simply runs a shell command, e.g.: https://github.com/spglib/spglib/pull/315/files#diff-9b6e070f697bf675cd4bc6193a4e168ca09b23dc1cd3b7ac0a0adeccb89f92b3R21-R24 and displays the output. I will update with a link of the example output. If you think it would be good to actually check the results of the output example, let me know, otherwise it's just a simple smoke test. The purpose for that additional test is to primarily check that the package is loaded correctly from cmake. I will alter it a bit later to check also FetchContent and pkg-config.

@atztogo
Copy link
Collaborator

atztogo commented Aug 16, 2023

@LecrisUT, thanks for your detailed explanation. All OK to me.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9957bfc) 83.60% compared to head (4e77c3d) 83.60%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #315   +/-   ##
========================================
  Coverage    83.60%   83.60%           
========================================
  Files           23       23           
  Lines         7942     7942           
========================================
  Hits          6640     6640           
  Misses        1302     1302           
Flag Coverage Δ
c_api 76.10% <ø> (ø)
fortran_api 36.82% <ø> (ø)
python_api 80.42% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/spglib.c 72.31% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT
Copy link
Collaborator Author

@atztogo @lan496 Check /distro/plans/examples -> /example/c_api here for an example of the tmt test runner

@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Aug 16, 2023

Waiting on: scikit-build/scikit-build-core#468 after which will re-run the CI and then merge this.

/packit test

@LecrisUT LecrisUT force-pushed the fix/313 branch 2 times, most recently from fc39df4 to a2b254d Compare August 16, 2023 15:00
@LecrisUT LecrisUT assigned LecrisUT and unassigned atztogo Aug 17, 2023
@LecrisUT LecrisUT force-pushed the fix/313 branch 8 times, most recently from 8eb7ce9 to 5446736 Compare August 17, 2023 14:05
@LecrisUT LecrisUT force-pushed the fix/313 branch 3 times, most recently from 992d71f to fdaee54 Compare August 17, 2023 15:29
@LecrisUT LecrisUT changed the title Fix fortran module install path Various fixes Aug 18, 2023
@LecrisUT LecrisUT force-pushed the fix/313 branch 2 times, most recently from ddeec05 to fd0484f Compare August 21, 2023 11:39
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Maximum theoretical primitive atoms is 4*num_atom

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT merged commit 4db87c3 into spglib:develop Aug 22, 2023
@LecrisUT LecrisUT deleted the fix/313 branch August 22, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fortran module install directory
4 participants