-
Notifications
You must be signed in to change notification settings - Fork 116
Various fixes #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes #315
Conversation
Thanks! I will defer to atztogo on this PR. |
@LecrisUT, could you tell me what I can review? I have really no idea about rpm. |
Basically only a4190b7. On the fortran side it just changes the installation location from The additional tmt packaging simply runs a shell command, e.g.: https://github.com/spglib/spglib/pull/315/files#diff-9b6e070f697bf675cd4bc6193a4e168ca09b23dc1cd3b7ac0a0adeccb89f92b3R21-R24 and displays the output. I will update with a link of the example output. If you think it would be good to actually check the results of the output example, let me know, otherwise it's just a simple smoke test. The purpose for that additional test is to primarily check that the package is loaded correctly from cmake. I will alter it a bit later to check also |
@LecrisUT, thanks for your detailed explanation. All OK to me. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #315 +/- ##
========================================
Coverage 83.60% 83.60%
========================================
Files 23 23
Lines 7942 7942
========================================
Hits 6640 6640
Misses 1302 1302
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Waiting on: scikit-build/scikit-build-core#468 after which will re-run the CI and then merge this. /packit test |
fc39df4
to
a2b254d
Compare
8eb7ce9
to
5446736
Compare
992d71f
to
fdaee54
Compare
ddeec05
to
fd0484f
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Maximum theoretical primitive atoms is 4*num_atom Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Closes #313