Skip to content

Conversation

LecrisUT
Copy link
Collaborator

It allows us to cache pip. Conda has its own CI anyway so it should be easier to maintain on our side.

@LecrisUT LecrisUT requested review from atztogo and lan496 June 20, 2023 07:40
@LecrisUT LecrisUT assigned LecrisUT, atztogo and lan496 and unassigned LecrisUT Jun 20, 2023
@atztogo
Copy link
Collaborator

atztogo commented Jun 20, 2023

Do we have to set CC?

@LecrisUT
Copy link
Collaborator Author

Do we have to set CC?

Oh thanks for notifying me. Hmm, it should pick up the default compiler, but it seems that on the CI /usr/bin/cc is explicitly deleted

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Copy link
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LecrisUT LecrisUT merged commit 4893b4d into spglib:develop Jun 20, 2023
@LecrisUT LecrisUT deleted the ci/native-pip branch June 20, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants