Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (4893b4d) to head (20a8ac0).
Report is 370 commits behind head on develop.

@@           Coverage Diff            @@
##           develop     #304   +/-   ##
========================================
  Coverage    83.64%   83.64%           
========================================
  Files           23       23           
  Lines         6274     6274           
========================================
  Hits          5248     5248           
  Misses        1026     1026           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT, are we waiting for windows test by #286?

For this one? No it's self-contained and all ready. Just need documentation review.

I asked because I have been bitten by windows compilers number of times in old days. So I may be relaxed if I could see this PR passes on windows compilers.

I asked because I have been bitten by windows compilers number of times in old days. So I may be relaxed if I could see this PR passes on windows compilers.

Oh in that sense. Sure this one is already a dependency for most of the PRs, #286 included. And indeed for that one the tests are passing (except the flakiness bug that I'm slowly trying to address with #303, #297 and other test improvements)

Ok, see #286. Windows tests are passing with the C11 even on pytest 🎉. I have confirmed that the correct compiler is used in https://github.com/spglib/spglib/actions/runs/5319593736

Hmm, it didn't allow to set an auto-merge, maybe it only has an effect on future PRs.