Skip to content

Conversation

atztogo
Copy link
Collaborator

@atztogo atztogo commented Jun 15, 2023

There has not been MagneticDataset support for fortran. This is the PR dedicated to it.

ToDo

  • Write tests

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -11.72 ⚠️

Comparison is base (94d288f) 85.92% compared to head (99c0c3e) 74.21%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #292       +/-   ##
============================================
- Coverage    85.92%   74.21%   -11.72%     
============================================
  Files           23       22        -1     
  Lines         6081     5588      -493     
============================================
- Hits          5225     4147     -1078     
- Misses         856     1441      +585     
Flag Coverage Δ
c_api 74.21% <ø> (ø)
fortran_api 37.38% <ø> (ø)
python_api ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LecrisUT

This comment was marked as resolved.

@LecrisUT LecrisUT added the enhancement Significant ehancements label Jun 15, 2023
@atztogo
Copy link
Collaborator Author

atztogo commented Sep 20, 2023

I made a fresh PR for this at #333.

@atztogo atztogo closed this Sep 20, 2023
@atztogo atztogo deleted the fortran-magdataset branch September 20, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Significant ehancements
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants