pre-commit fails due to clang-format. @lan496, previously clang-format didn't check following lines?

-    int (*steps[8])(NiggliParams *p) = {step1, step2, step3, step4,
-                                        step5, step6, step7, step8};
+    int (*steps[8])(NiggliParams * p) = {step1, step2, step3, step4,
+                                         step5, step6, step7, step8};

@atztogo It seems. In my local environment (clang-format==16.0.4), formatted to int (*steps[8])(NiggliParams *p), but CI's clang-format complains about it.

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (3800c46) 85.92% compared to head (0733349) 85.92%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #278      +/-   ##
===========================================
- Coverage    85.92%   85.92%   -0.01%     
===========================================
  Files           23       23              
  Lines         6082     6081       -1     
===========================================
- Hits          5226     5225       -1     
  Misses         856      856              

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LecrisUT It seems the versions of clang-format in my environment and CI are diffenrent. The CI's clang-format will be handled at https://github.com/Takishima/cmake-pre-commit-hooks. Do you know how to know and specify the clang-format version in CI?

@atztogo It seems. In my local environment (clang-format==16.0.4), formatted to int (*steps[8])(NiggliParams *p), but CI's clang-format complains about it.

Oh yeah I had this issue before. We can use pre-commit-ci to get newer versions and/or use a container with pre-installed modern clang-format.

Also have to check if we can we can enforce a clang-format minimum version.

@LecrisUT It seems the versions of clang-format in my environment and CI are diffenrent. The CI's clang-format will be handled at https://github.com/Takishima/cmake-pre-commit-hooks. Do you know how to know and specify the clang-format version in CI?

Oh, I didn't know there is a PyPI version of clang-format as well (reference). Maybe can specify the version there.

At

 - repo: https://github.com/Takishima/cmake-pre-commit-hooks 
   rev: v1.5.3 
   hooks: 
     - id: clang-format 
       additional_dependencies: [ clang-format >= 16 ]

OK, it seems the CI uses clang-format>=16 now! I'll clean up the commits.

Add to todo:

• warning regarding passing non-const array to const array. That should be perfectly fine, but why does the compiler trigger a warning about it
• uninitialized warnings should be fixed
• make warnings become error: CMAKE_COMPILE_WARNING_AS_ERROR

@LecrisUT, can we merge this PR to merge #278 ?

@LecrisUT I've fixed to use target_compile_option(PRIVATE): 5086f74

Ok, the final issue is about my last comment

Add to todo:

* warning regarding passing non-const array to const array. That should be perfectly fine, but why does the compiler trigger a warning about it

* uninitialized warnings should be fixed

* make warnings become error: [`CMAKE_COMPILE_WARNING_AS_ERROR`](https://cmake.org/cmake/help/latest/variable/CMAKE_COMPILE_WARNING_AS_ERROR.html#variable:CMAKE_COMPILE_WARNING_AS_ERROR)

Can you make an issue about it if we are not addressing these issues in this PR?

Sure! I've opened the issue #289.