Skip to content

Conversation

LecrisUT
Copy link
Collaborator

Codecov package has not been needed and recently it got removed. Fully remove the package dependency

Codecov package has not been needed and recently it got removed. Fully remove the package dependency

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT added the bug label Apr 13, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +11.71 🎉

Comparison is base (77a8e5d) 74.21% compared to head (591f572) 85.92%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #270       +/-   ##
============================================
+ Coverage    74.21%   85.92%   +11.71%     
============================================
  Files           22       23        +1     
  Lines         5588     6081      +493     
============================================
+ Hits          4147     5225     +1078     
+ Misses        1441      856      -585     
Flag Coverage Δ
c_api 74.21% <ø> (ø)
fortran_api 37.38% <ø> (ø)
python_api 82.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LecrisUT LecrisUT merged commit d826c2d into spglib:develop Apr 13, 2023
@LecrisUT LecrisUT deleted the fix/codecov branch April 13, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants