Skip to content

Clarify non-collinear magmoms in Python interface #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2023
Merged

Clarify non-collinear magmoms in Python interface #265

merged 1 commit into from
Mar 21, 2023

Conversation

lan496
Copy link
Member

@lan496 lan496 commented Mar 20, 2023

Fixes #256

@lan496 lan496 requested a review from atztogo March 20, 2023 07:46
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a8c5d7) 85.69% compared to head (6e060fd) 85.69%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #265   +/-   ##
========================================
  Coverage    85.69%   85.69%           
========================================
  Files           23       23           
  Lines         6069     6069           
========================================
  Hits          5201     5201           
  Misses         868      868
Flag Coverage Δ
c_api 73.70% <ø> (ø)
fortran_api 37.37% <ø> (ø)
python_api 82.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

atztogo
atztogo approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@atztogo atztogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks.

@atztogo atztogo merged commit 06f1799 into spglib:develop Mar 21, 2023
@lan496 lan496 deleted the fix-noncollinear-doc branch March 21, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atztogo atztogo atztogo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarification on how to prepare magmoms in Python interface
3 participants
@lan496 @codecov-commenter @atztogo