Use tag format for PyPi action #250
Conversation
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Codecov ReportBase: 85.69% // Head: 73.92% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #250 +/- ##
============================================
- Coverage 85.69% 73.92% -11.78%
============================================
Files 23 22 -1
Lines 6069 5576 -493
============================================
- Hits 5201 4122 -1079
- Misses 868 1454 +586
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@LecrisUT Thanks. Can you update |
|
Oh yeah, forgot about that |
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
There was a problem hiding this comment.
@LecrisUT The instruction of Contributing.md looks nice! I've checked to run wheel-building CI in my forked repo.
https://github.com/lan496/spglib/actions/runs/4289284752
|
@lan496 can you edit the pyproject.toml and push tag |
|
@LecrisUT Sure. Which branch is appropriate to push in this case? |
|
It is commit specific, but add a commit to edit pyproject.toml on develop and tag that commit. |
|
Great, thanks. For some reason I am able to create releases, even though I can't push tags :)) |
|
Sorry, I didn't notice "write" role cannot push tags. I'll add you "Maintain" role. |
|
Thanks, didn't know the difference in the roles either. |
This is taken from #241