Skip to content

Conversation

lan496
Copy link
Member

@lan496 lan496 commented Jan 20, 2023

This PR just merges #218 to develop.

atztogo and others added 14 commits January 15, 2023 16:14
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Good luck!

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Move to `pyproject.toml` build
@lan496 lan496 requested a review from atztogo January 20, 2023 00:54
@codecov-commenter
Copy link

Codecov Report

Base: 64.00% // Head: 93.61% // Increases project coverage by +29.60% 🎉

Coverage data is based on head (9c5b02c) compared to base (6b4332c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #219       +/-   ##
============================================
+ Coverage    64.00%   93.61%   +29.60%     
============================================
  Files           18       15        -3     
  Lines         1328      908      -420     
============================================
  Hits           850      850               
+ Misses         478       58      -420     
Impacted Files Coverage Δ
test/test_rhomb_H_and_R.py
test/vasp.py
spglib/__init__.py
test/test_benchmark.py
spglib/spglib.py
test/test_layergroup.py
test/test_pure_trans.py
test/test_site_tensors.py
test/test_niggli_delaunay.py
test/test_spacegrouop_type_from_symmetry.py
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@atztogo atztogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Thanks! Let's see in develop.

@lan496 lan496 merged commit dbc88b8 into develop Jan 20, 2023
@LecrisUT LecrisUT deleted the rc branch August 12, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants