Skip to content

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Feb 28, 2025

I've ended up doing a heavy refactor of the testsuite:

  • Extracted all .xz files
  • Moved from unittest to pytest fixtures
  • Moved all data dependent tests to use a common fixture
  • Because of pytest_generate_tests all tests are now expanded and can be selected individually
  • Reuse dataset where possible

Closes #550
Closes #291

@LecrisUT LecrisUT mentioned this pull request Feb 28, 2025
@LecrisUT LecrisUT force-pushed the fix/550 branch 3 times, most recently from 627d941 to 1f851a1 Compare March 2, 2025 20:02
@LecrisUT LecrisUT requested review from atztogo and lan496 March 2, 2025 20:06
@LecrisUT LecrisUT changed the title fix: Extract .xz files refactor: Improved python test fixtures Mar 2, 2025
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.34%. Comparing base (0642066) to head (a8a6b6b).
Report is 19 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #556   +/-   ##
========================================
  Coverage    74.34%   74.34%           
========================================
  Files           26       26           
  Lines         8069     8069           
  Branches      1691     1689    -2     
========================================
  Hits          5999     5999           
  Misses        1561     1561           
  Partials       509      509           
Flag Coverage Δ
c_api 68.68% <ø> (ø)
fortran_api 50.70% <ø> (ø)
python_api 67.71% <ø> (ø)
unit_tests 11.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LecrisUT LecrisUT force-pushed the fix/550 branch 3 times, most recently from 79db0b8 to a03821f Compare March 2, 2025 21:08
Copy link
Collaborator

@atztogo atztogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lan496
Copy link
Member

lan496 commented Mar 2, 2025

Packit-as-a-Service failed as always. Do we need to merge #558 first?

@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Mar 2, 2025

Packit-as-a-Service failed as always. Do we need to merge #558 first?

It will be broken for a while until scikit-build-core 0.11 lands in Fedora-rawhide. I'm waiting on a few dependencies and probably tomorrow will try to resolve them.

LecrisUT added 4 commits March 5, 2025 09:55
Signed-off-by: Cristian Le <git@lecris.dev>
- Convert everything to pytest
- Moved generators to common fixtures
@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Mar 5, 2025

/packit build

@LecrisUT LecrisUT merged commit b589ef7 into spglib:develop Mar 5, 2025
45 of 53 checks passed
@LecrisUT LecrisUT deleted the fix/550 branch May 28, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review commit 791777d Improve pytets
3 participants