Skip to content

chore: unblock CI #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2024
Merged

chore: unblock CI #535

merged 1 commit into from
Nov 9, 2024

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Nov 9, 2024

  • bump gtest FetchContent version

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.24%. Comparing base (0c1fca6) to head (ece7f1e).
Report is 52 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #535      +/-   ##
===========================================
+ Coverage    84.12%   84.24%   +0.11%     
===========================================
  Files           26       26              
  Lines         8122     8209      +87     
  Branches      1702     1695       -7     
===========================================
+ Hits          6833     6916      +83     
- Misses        1289     1293       +4
Flag Coverage Δ
c_api 75.52% <ø> (+0.12%) ⬆️
fortran_api 56.43% <ø> (+0.14%) ⬆️
python_api 81.56% <ø> (+0.16%) ⬆️
unit_tests 13.60% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT LecrisUT marked this pull request as ready for review November 9, 2024 06:48
@LecrisUT LecrisUT mentioned this pull request Nov 9, 2024
Merged
@atztogo
Copy link
Collaborator

atztogo commented Nov 9, 2024

Can I merge this though testing-farm:fedra's fail?

@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Nov 9, 2024

Yes, I don't quite know the reason it failed there, but I'll have to refactor it later

@atztogo atztogo merged commit 35c6693 into spglib:develop Nov 9, 2024
57 of 59 checks passed
@LecrisUT LecrisUT deleted the chore/unblock-ci branch November 9, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LecrisUT @atztogo