Skip to content

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Aug 12, 2024

I recently reviewed the usage of test.pypi.org and found this is a significant issue, because dependencies, in this case numpy is not guaranteed to be present there. Instead in order to get release candidates, the user should either:

$ pip install --pre spglib

which would propagate to the dependencies as well, or simply

$ pip install spglib==x.y.zrc1

@LecrisUT LecrisUT requested review from atztogo and lan496 August 12, 2024 14:26
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.12%. Comparing base (1bf919a) to head (94d04ae).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #523   +/-   ##
========================================
  Coverage    84.12%   84.12%           
========================================
  Files           26       26           
  Lines         8122     8122           
  Branches      1697     1697           
========================================
  Hits          6833     6833           
  Misses        1289     1289           
Flag Coverage Δ
c_api 75.39% <ø> (ø)
fortran_api 56.29% <ø> (ø)
python_api 81.39% <ø> (ø)
unit_tests 13.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atztogo
Copy link
Collaborator

atztogo commented Aug 13, 2024

What is the purpose of having (or not having) TestPyPI package?

@LecrisUT
Copy link
Collaborator Author

The test.pypi.org repo is only meant to test the upload works properly. The packages inside are not meant to be relied upon. An issue mentioned is that if you point it to install from there, the dependencies are not searched for from the normal pypi repo, which would naturally fail because numpy2.x is not available.

@atztogo
Copy link
Collaborator

atztogo commented Aug 13, 2024

The test.pypi.org repo is only meant to test the upload works properly.

For example, is it enough to write "please don't install spglib from test.pypi" at https://test.pypi.org/project/spglib/ ?

@LecrisUT
Copy link
Collaborator Author

For example, is it enough to write "please don't install spglib from test.pypi" at https://test.pypi.org/project/spglib/ ?

I think rather not mention anything and keep the documentation minimal. The concept of test.pypi will gradually fade away, and when needed it is easier to write a quick comment to an issue. Alternatively, we could point them to upstream pip documentation?

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT force-pushed the fix/remove-test-pypi branch from bfb408f to 94d04ae Compare August 13, 2024 08:09
@atztogo
Copy link
Collaborator

atztogo commented Aug 13, 2024

Alternatively, we could point them to upstream pip documentation?

This is beyond my ability to comment.

@LecrisUT
Copy link
Collaborator Author

Alternatively, we could point them to upstream pip documentation?

This is beyond my ability to comment.

For reference: https://pip.pypa.io/en/stable/cli/pip_install/

@lan496 lan496 merged commit d9c572d into spglib:develop Aug 13, 2024
56 checks passed
@LecrisUT LecrisUT deleted the fix/remove-test-pypi branch September 11, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants