-
Notifications
You must be signed in to change notification settings - Fork 116
fix: Remove usage of test.pypi.org
#523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #523 +/- ##
========================================
Coverage 84.12% 84.12%
========================================
Files 26 26
Lines 8122 8122
Branches 1697 1697
========================================
Hits 6833 6833
Misses 1289 1289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What is the purpose of having (or not having) TestPyPI package? |
The |
For example, is it enough to write "please don't install spglib from test.pypi" at https://test.pypi.org/project/spglib/ ? |
I think rather not mention anything and keep the documentation minimal. The concept of test.pypi will gradually fade away, and when needed it is easier to write a quick comment to an issue. Alternatively, we could point them to upstream pip documentation? |
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
bfb408f
to
94d04ae
Compare
This is beyond my ability to comment. |
For reference: https://pip.pypa.io/en/stable/cli/pip_install/ |
I recently reviewed the usage of
test.pypi.org
and found this is a significant issue, because dependencies, in this casenumpy
is not guaranteed to be present there. Instead in order to get release candidates, the user should either:$ pip install --pre spglib
which would propagate to the dependencies as well, or simply