Skip to content

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 5, 2024

This PR contains the following updates:

Package Type Update Change
astral-sh/ruff-pre-commit repository minor v0.5.6 -> v0.9.3
codespell-project/codespell repository minor v2.3.0 -> v2.4.0
executablebooks/mdformat repository patch 0.7.17 -> 0.7.21
lukka/run-cmake action minor v10.5 -> v10.8
lukka/run-cmake action minor v10.7 -> v10.8
pre-commit/mirrors-mypy repository minor v1.11.1 -> v1.14.1
pre-commit/pre-commit-hooks repository major v4.6.0 -> v5.0.0
pypa/cibuildwheel action minor v2.19 -> v2.22
python-jsonschema/check-jsonschema repository minor 0.29.1 -> 0.31.0

Note: The pre-commit manager in Renovate is not supported by the pre-commit maintainers or community. Please do not report any problems there, instead create a Discussion in the Renovate repository if you have any questions.


Release Notes

astral-sh/ruff-pre-commit (astral-sh/ruff-pre-commit)

v0.9.3

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.9.3

v0.9.2

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.9.2

v0.9.1

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.9.1

v0.9.0

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.9.0

v0.8.6

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.8.6

v0.8.5

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.8.5

v0.8.4

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.8.4

v0.8.3

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.8.3

v0.8.2

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.8.2

v0.8.1

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.8.1

v0.8.0

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.8.0

v0.7.4

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.7.4

v0.7.3

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.7.3

v0.7.2

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.7.2

v0.7.1

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.7.1

v0.7.0

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.7.0

v0.6.9

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.6.9

v0.6.8

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.6.8

v0.6.7

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.6.7

v0.6.6

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.6.6

v0.6.5

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.6.5

v0.6.4

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.6.4

v0.6.3

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.6.3

v0.6.2

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.6.2

v0.6.1

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.6.1

v0.6.0

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.6.0

v0.5.7

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.5.7

codespell-project/codespell (codespell-project/codespell)

v2.4.0

Compare Source

What's Changed
New Contributors

Full Changelog: codespell-project/codespell@v2.3.0...v2.4.0

executablebooks/mdformat (executablebooks/mdformat)

v0.7.21

Compare Source

v0.7.20

Compare Source

v0.7.19

Compare Source

v0.7.18

Compare Source

lukka/run-cmake (lukka/run-cmake)

v10.8: run-cmake@v10.8

Compare Source

Changes:

  • Fix the matcher for the MSVC cl.exe compiler to account for the column (if present) of the error/warning location.

Note: to keep your workflow up to date with bug and security fixes, just use v10 branch to stay on the most recent v10.x version of this action, e.g., uses: lukka/run-cmake@v10

v10.7: run-cmake@v10.7

Compare Source

Changes:

  • Update the action to require node v20, since v16 is out of support. If any problem occurs, please use run-cmake@v10.6and create an issue.
  • Update dependencies to most recent ones: all libs and @actions packages update to most recent versions, along with all other dependencies.
  • Drop usage of gulp.
  • Update docs.

Note: to keep your workflow up to date with bug and security fixes, just use v10 branch to stay on the most recent v10.x version of this action, e.g., uses: lukka/run-cmake@v10

v10.6: run-cmake@v10.6

Compare Source

Changes:

  • Since May 2023 the GitHub Runners for Windows contain Visual Studio 2022 17.6, whose VS Developer Command Prompt (or Developer Powershell) defines the VCPKG_ROOT value. The change is that the run-cmake action avoids changing the value of VCPKG_ROOT when setting up the MSVC environment.

Note: to keep your workflow up to date with bug and security fixes, just use v10 branch to stay on the most recent v10.x version of this action, e.g., uses: lukka/run-cmake@v10

pre-commit/mirrors-mypy (pre-commit/mirrors-mypy)

v1.14.1

Compare Source

v1.14.0

Compare Source

v1.13.0

Compare Source

v1.12.1

Compare Source

v1.12.0

Compare Source

v1.11.2

Compare Source

pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)

v5.0.0: pre-commit-hooks v5.0.0

Compare Source

Features
Fixes
Migrating
  • pre-commit-hooks now requires pre-commit>=3.2.0.
  • use non-deprecated names for stages.
pypa/cibuildwheel (pypa/cibuildwheel)

v2.22

Compare Source

v2.21

Compare Source

v2.20

Compare Source

python-jsonschema/check-jsonschema (python-jsonschema/check-jsonschema)

v0.31.0

Compare Source

  • Update vendored schemas: azure-pipelines, bamboo-spec, buildkite, circle-ci,
    dependabot, gitlab-ci, mergify, readthedocs, renovate, taskfile (2025-01-07)

  • Drop support for Python 3.8

  • Rename --format-regex to --regex-variant and convert
    --format-regex to a deprecated alias.
    It will be removed in a future release.

  • Regular expression interpretation in "pattern", "patternProperties", and
    "format": "regex" usages now uses unicode-mode JS regular expressions by
    default. (:issue:353)

    • Use --regex-variant nonunicode to get non-unicode JS regular
      expressions, the default behavior from previous versions.
    • Custom validators may be impacted by the new regular expression
      features. Validators are now always modified with the jsonschema
      library's extend() API to control the pattern and
      patternProperties keywords.

v0.30.0

Compare Source

  • Update vendored schemas: azure-pipelines, bitbucket-pipelines, buildkite,
    circle-ci, cloudbuild, dependabot, github-workflows, gitlab-ci, mergify,
    readthedocs, renovate, taskfile, woodpecker-ci (2024-11-29)
  • Fix caching behavior to always use URL hashes as cache keys. This fixes a
    cache confusion bug in which the wrong schema could be retrieved from the
    cache. This resolves :cve:2024-53848. Thanks :user:sethmlarson for reporting!
  • Deprecate the --cache-filename flag. It no longer has any effect and will
    be removed in a future release.

v0.29.4

Compare Source

  • Update vendored schemas: azure-pipelines, github-workflows, gitlab-ci,
    mergify, renovate (2024-10-06)
  • Fix the renovate hook to allow for .renovaterc.json5 as well. Thanks
    :user:tpansino! (:pr:491)
  • Add Mergify schema and pre-commit hook. Thanks :user:hofbi and :user:jd
    for the issue and feedback! (:issue:487)

v0.29.3

Compare Source

  • Update vendored schemas: buildkite, circle-ci, dependabot, gitlab-ci,
    renovate, taskfile, woodpecker-ci (2024-09-29)

v0.29.2

Compare Source

  • Update vendored schemas: buildkite, github-workflows, gitlab-ci, renovate,
    woodpecker-ci (2024-08-22)
  • Convert from setup.cfg to pyproject.toml for python package metadata

Configuration

📅 Schedule: Branch creation - "* 0-3 * * 1" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 4 times, most recently from 2be5340 to 493ae23 Compare August 12, 2024 22:59
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 3 times, most recently from 4fee06c to 430f694 Compare August 17, 2024 11:35
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 3 times, most recently from 223b574 to f3cb1ff Compare August 30, 2024 11:39
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 2 times, most recently from 558b36c to feb622f Compare September 11, 2024 05:32
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch from feb622f to a204a7a Compare September 14, 2024 08:29
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 3 times, most recently from 4a78abe to 2c57171 Compare September 27, 2024 11:51
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 4 times, most recently from 8b9b5fc to 5e02030 Compare October 7, 2024 09:38
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 3 times, most recently from 6d820ba to fb9ad1a Compare October 18, 2024 20:57
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 3 times, most recently from 61e85f3 to f7f49eb Compare October 25, 2024 08:57
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 3 times, most recently from cc748a8 to 14dc553 Compare November 9, 2024 07:41
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch from 14dc553 to 7b87a60 Compare November 10, 2024 05:54
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 2 times, most recently from 140c868 to 2e0d665 Compare November 23, 2024 08:55
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 2 times, most recently from 35cfc8e to 2b760b6 Compare November 30, 2024 02:23
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 2 times, most recently from c9d9e33 to 41cf8a0 Compare December 12, 2024 07:12
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch from 41cf8a0 to 48ba077 Compare December 14, 2024 02:05
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch from 48ba077 to d1851e2 Compare December 21, 2024 14:54
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 4 times, most recently from d997ed0 to b6ff7b4 Compare January 5, 2025 11:49
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch 2 times, most recently from 3523342 to f1e71aa Compare January 11, 2025 11:07
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch from f1e71aa to c955263 Compare January 17, 2025 15:44
@lan496 lan496 force-pushed the renovate/ci-and-devdependencies branch from bf44379 to 959e74e Compare January 19, 2025 13:30
@lan496
Copy link
Member

lan496 commented Jan 19, 2025

@LecrisUT The coverage CIs have started to break, and I think it does not directly relate to this PR. Do you know what is happening?
https://github.com/spglib/spglib/actions/runs/12854022155/job/35837946344?pr=522

@LecrisUT
Copy link
Collaborator

Thanks for looking into this PR. I was a bit wary of lcov-action because it uses a docker container approach and it seems we have 2 issues here:

  • lcov seems to recently complain if a pattern is not used
  • in the python run, it seems to look for numpy related headers which are never available because we are using build-isolation

Fixing these will be tricky I think, but instead I am considering one of the 2 options

  • codecov: remove the lcov-action and rely on codecov to extract all coverage data. We would need to migrate all exclusion flags to codecov.yaml 1. One downside of this I can think of right now is that it is harder to replicate locally and get a local report.
  • gcovr: this would be ci: Switch coverage to gcovr #403. This gives a bit more control over the exclusion paths and is more replicable locally. I don't remember what the issue was with that one, but it's worth re-exploring as the underlying tools evolve.

We could go with codecov approach for a quick solution for now and then see if #403 is still desirable.


I was looking at the format commit and I am quite surprised at the suggestion in the pre-commit because the original one is actually more correct. I'll open an issue upstream to see what's going on

Footnotes

  1. https://docs.codecov.com/docs/ignoring-paths

@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch from 959e74e to e1b4937 Compare January 20, 2025 18:16
@renovate renovate bot force-pushed the renovate/ci-and-devdependencies branch from e1b4937 to 9133429 Compare January 24, 2025 07:09
@LecrisUT LecrisUT mentioned this pull request Jan 29, 2025
@LecrisUT
Copy link
Collaborator

I had time to debug the mdformat change and it's related to hukkin/mdformat#112, and it seems that they keep the brackets un-escapped if they are valid, e.g. like how GH accepts [this] without escaping. They seem fine, so I guess we keep them

- outdated comment removed
- move back to v10 tracking
Copy link
Contributor Author

renovate bot commented Jan 29, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.20%. Comparing base (e1d4fa1) to head (12e6f39).
Report is 59 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #522   +/-   ##
========================================
  Coverage    77.20%   77.20%           
========================================
  Files           26       26           
  Lines         8082     8082           
  Branches      1697     1690    -7     
========================================
  Hits          6240     6240           
  Misses        1347     1347           
  Partials       495      495           
Flag Coverage Δ
c_api 68.68% <ø> (ø)
fortran_api 50.70% <ø> (ø)
python_api 73.24% <ø> (ø)
unit_tests 11.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LecrisUT
Copy link
Collaborator

LecrisUT commented Jan 29, 2025

So... cibuildwheel runners for linux arm running with emulations seem to be broken. Let's see if #547 fixes it. (yeah it did)

@LecrisUT LecrisUT merged commit 12e6f39 into develop Jan 29, 2025
54 of 56 checks passed
@lan496 lan496 deleted the renovate/ci-and-devdependencies branch January 30, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants