fix: Move the inlined debug definitions to header
#519
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #519 +/- ##
===========================================
+ Coverage 83.90% 83.96% +0.05%
===========================================
Files 25 26 +1
Lines 8185 8122 -63
Branches 1701 1702 +1
===========================================
- Hits 6868 6820 -48
+ Misses 1317 1302 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@LecrisUT Can you rebase this PR with develop? |
Unclear how `extern inline` is supposed to work, but we only care about inlining the functions for the case where they are empty (not sure if the compiler can do it without it regardless). Using `static inline` to define the empty functions when needed (`extern inline` gave multiple definition issues) Signed-off-by: Cristian Le <git@lecris.dev>
Feel free to use the |
|
Then, testing-farm:fedora-* start failing 🤔 |
Yeah, reported upstream: https://status.testing-farm.io/. ETA they gave is 1-2h. Feel free to enable auto-merge and I'll come back to restart it when the problem is resolved |
Switched it up a bit, basically we only care about inlining when the printing is empty, so I just moved those definitions in the header itself with the appropriate guard. When the printing is needed, than it would just create normal functions.
Closes #516