Skip to content

Conversation

henryiii
Copy link
Contributor

No description provided.

@henryiii
Copy link
Contributor Author

The good news is the release is fine. Just download the artifacts manually, make sure there are no duplicates, then upload them with twine. It doesn't matter if you take the macOS 11 or 13 downloads, just don't take both. (14 will be ARM, 11-13 was Intel). Also don't take the wheel output from build-and-inspect-python-package, only the SDist.

@LecrisUT
Copy link
Collaborator

I think we need a twine check on the wheels as well, to avoid this issue happening again. Thanks for the quick fix :)

@henryiii
Copy link
Contributor Author

henryiii commented Apr 11, 2024

Simply trying to unzip the file would catch it, actually, since actions/download-artifact#298 garbles the bits together instead of erroring out, making invalid zips. :) (yes, twine check should be doing this. In my experience it is really limited in what it can catch, but I'd think this is one thing it could do!)

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.80%. Comparing base (273ed90) to head (08f5d94).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #471   +/-   ##
========================================
  Coverage    83.80%   83.80%           
========================================
  Files           25       25           
  Lines         8164     8164           
  Branches      1705     1705           
========================================
  Hits          6842     6842           
  Misses        1322     1322           
Flag Coverage Δ
c_api 74.71% <ø> (ø)
fortran_api 56.20% <ø> (ø)
python_api 80.04% <ø> (ø)
unit_tests 13.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT
Copy link
Collaborator

Yey, issue resolved, just had to delete one of the artifacts and re-run the CI. Still would be good to try and catch these issues in this PR. Could hynek/build-and-inspect-python-package use the artifacts from cibuildwheel?

@LecrisUT LecrisUT mentioned this pull request Apr 11, 2024
@LecrisUT
Copy link
Collaborator

I've added a simple twine check sanity check. @henryiii do you have anything more here or 🟢 to merge?

@LecrisUT LecrisUT marked this pull request as ready for review April 23, 2024 15:51
@LecrisUT LecrisUT enabled auto-merge (squash) April 23, 2024 15:51
@LecrisUT LecrisUT merged commit 69da2b8 into spglib:develop Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants