-
Notifications
You must be signed in to change notification settings - Fork 116
ci: fix wheel build #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix wheel build #471
Conversation
The good news is the release is fine. Just download the artifacts manually, make sure there are no duplicates, then upload them with twine. It doesn't matter if you take the macOS 11 or 13 downloads, just don't take both. (14 will be ARM, 11-13 was Intel). Also don't take the wheel output from build-and-inspect-python-package, only the SDist. |
I think we need a |
Simply trying to unzip the file would catch it, actually, since actions/download-artifact#298 garbles the bits together instead of erroring out, making invalid zips. :) (yes, twine check should be doing this. In my experience it is really limited in what it can catch, but I'd think this is one thing it could do!) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #471 +/- ##
========================================
Coverage 83.80% 83.80%
========================================
Files 25 25
Lines 8164 8164
Branches 1705 1705
========================================
Hits 6842 6842
Misses 1322 1322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yey, issue resolved, just had to delete one of the artifacts and re-run the CI. Still would be good to try and catch these issues in this PR. Could |
I've added a simple |
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
No description provided.