Skip to content

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Feb 26, 2024

For now I have only converted my IDE's view to use spaces, I did not go through it to see if I should change the sizes

Closes: #446

@LecrisUT LecrisUT requested a review from lan496 February 26, 2024 09:22
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.59%. Comparing base (cdf91e8) to head (8944857).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #448   +/-   ##
========================================
  Coverage    83.59%   83.59%           
========================================
  Files           24       24           
  Lines         8118     8118           
  Branches      1693     1686    -7     
========================================
  Hits          6786     6786           
  Misses        1332     1332           
Flag Coverage Δ
c_api 74.43% <ø> (ø)
fortran_api 56.16% <ø> (ø)
python_api 79.70% <ø> (ø)
unit_tests 13.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 4 spaces for a tab look nice.

@LecrisUT LecrisUT requested a review from atztogo February 26, 2024 23:21
@lan496
Copy link
Member

lan496 commented Feb 27, 2024

Can you resolve conflicts?

@LecrisUT
Copy link
Collaborator Author

Yes, I need to rebase again after #452

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT enabled auto-merge (squash) February 27, 2024 10:01
@LecrisUT LecrisUT merged commit 7945756 into spglib:develop Feb 27, 2024
@LecrisUT LecrisUT deleted the format/cmake branch February 29, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Consider using spaces instead of tabs
3 participants