ci: Build and inspect the sdist package #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #402 +/- ##
========================================
Coverage 83.59% 83.59%
========================================
Files 24 24
Lines 8119 8119
Branches 1687 1687
========================================
Hits 6787 6787
Misses 1332 1332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2882437 to
339f175
Compare
eedcf75 to
13fa0a6
Compare
|
For this one we can just push a quick |
lan496
reviewed
Feb 13, 2024
| with: | ||
| name: artifact | ||
| name: Packages |
There was a problem hiding this comment.
The artifact name Packages comes from https://github.com/hynek/build-and-inspect-python-package/blob/20db83a776feefaf52e2b2ba11475569a64f9bd2/action.yml#L60-L64
lan496
approved these changes
Feb 13, 2024
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
13fa0a6 to
f7858fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the CD workflow and add some downstream checker
Testing on my fork: https://github.com/LecrisUT/spglib/actions/workflows/release.yaml