mpich: support --with-device=ch3:sock:tcp #40964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @vicentebolea |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1868e5b to
2480ddd
Compare
raffenet
reviewed
Nov 14, 2023
2480ddd to
bde001b
Compare
bde001b to
1ea9e20
Compare
|
Force pushed in the hopes it will trigger readthedocs this time, as it has been "Expected" for the past few days. |
raffenet
approved these changes
Nov 17, 2023
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADIOS2 testing in CI (github actions) runs signifcantly slower when it is built against mpich rather than openmpi. The difference is roughly a factor of 2 (tests finish in under 30 minutes when built against openmpi, the same number of tests take around 1 hr when built against mpich).
Based on this comment on an mpich issue where someone else faced the same thing, we tried building mpich using
--with-device=ch3:sock:tcp, and discovered a significant speedup.This PR adds support so spack can build a version of mpich useful for testing in CI, where few available cores makes oversubscription more of a problem.