Skip to content

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jun 14, 2025

Many miscellaneous doc updates, fixes, and upgrades.

TODO:

Fixes #3112
Fixes #3069
Fixes #3055
Fixes #3004
Fixes #2900
Fixes #2891
Fixes #3653
Fixes #3543

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.21%. Comparing base (c9732cd) to head (adc884e).
Report is 1 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3681      +/-   ##
==========================================
+ Coverage   88.20%   88.21%   +0.01%     
==========================================
  Files         137      137              
  Lines       23534    23534              
  Branches     2275     2275              
==========================================
+ Hits        20757    20760       +3     
+ Misses       2466     2463       -3     
  Partials      311      311              
Flag Coverage Δ
hypothesis-py 25.40% <ø> (ø)
python 92.62% <ø> (ø)
rust 82.43% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctb ctb changed the title WIP: small docs fixes and updates MRG: small docs fixes and updates Jun 18, 2025
@ctb
Copy link
Contributor Author

ctb commented Jun 18, 2025

Ready for review & merge @sourmash-bio/devs

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nitpicks, otherwise Lgtm. I think it's important to note that multisearch/pairwise are much lower in memory than compare, though I need to go digging to see if we have numbers.

@@ -197,6 +205,7 @@ Optional arguments:
```
### `sourmash compare` - compare many signatures

**Note:** As of 2025, we have a much faster implementation of `compare` called `multisearch` available in [the branchwater plugin](https://github.com/sourmash-bio/sourmash_plugin_branchwater). It is multithreaded and should be (at worst) equivalent in memory usage, although it does accept a slightly more restricted set of inputs than `compare`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much lower in memory I think --will have to look at benchmarking in the issues. Compare is just not even feasible at large scale.

Related commands:
* `sourmash compare` will compare many sketches to many sketches.
* `sourmash prefetch` is an upgraded version of `search` that returns more information in the output CSV file.
* `sourmash scripts multisearch` from [the branchwater plugin](https://github.com/sourmash-bio/sourmash_plugin_branchwater) will search multiple sketches against a database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean manysearch here instead of multisearch? If yes, maybe add: ...and provides abundance-weighted results/information. If not, maybe worth mentioning here too?

@bluegenes
Copy link
Contributor

Hmm, it's possible I'm just thinking of the memory reductions from using pairwise, I can't seem to find multisearch vs compare benchmarking at the moment.

@ctb
Copy link
Contributor Author

ctb commented Jun 19, 2025

Both are good catches, thanks! I was being lazy on the memory statement - I think you're right, it's much lower memory.

@ctb
Copy link
Contributor Author

ctb commented Jun 19, 2025

@bluegenes see adc884e.

@ctb ctb merged commit a87ec47 into latest Jun 19, 2025
42 of 43 checks passed
@ctb ctb deleted the update_docs branch June 19, 2025 15:33
@ctb ctb mentioned this pull request Jun 28, 2025
ctb added a commit that referenced this pull request Jun 28, 2025
Cleanup and documentation updates:

* minor updates to release docs (#3695)
* small docs fixes and updates (#3681)

Developer updates:

* release core 0.21.0 (#3712)

Dependabot updates:

* Build(deps): Bump camino from 1.1.9 to 1.1.10 (#3669)
* Build(deps): Bump cfg-if from 1.0.0 to 1.0.1 (#3689)
* Build(deps): Bump conda-incubator/setup-miniconda from 3.1.1 to 3.2.0
(#3676)
* Build(deps): Bump getset from 0.1.5 to 0.1.6 (#3700)
* Build(deps): Bump prefix-dev/setup-pixi from 0.8.8 to 0.8.10 (#3688)
* Build(deps): Bump proptest from 1.6.0 to 1.7.0 (#3674)
* Build(deps): Bump pypa/cibuildwheel from 2.23.3 to 3.0.0 (#3687)
* Build(deps): Bump roaring from 0.10.12 to 0.11.0 (#3702)
* Build(deps): Update maturin requirement from <1.9.0,>=1 to >=1,<1.10.0
(#3699)
* Build(deps): Update pytest requirement from <8.4.0,>=6.2.4 to
>=6.2.4,<8.5.0 (#3670)
* EXP: Revert "Build(deps): Bump pypa/cibuildwheel from 2.23.3 to 3.0.0
(#3687) (#3691)
* [pre-commit.ci] pre-commit autoupdate (#3668)
* [pre-commit.ci] pre-commit autoupdate (#3673)
* [pre-commit.ci] pre-commit autoupdate (#3698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment