MRG: make RevIndex.len() and RevIndex.signatures() use picklist, if set
#3647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3647 +/- ##
==========================================
- Coverage 88.32% 88.21% -0.12%
==========================================
Files 137 137
Lines 23501 23534 +33
Branches 2274 2275 +1
==========================================
+ Hits 20757 20760 +3
- Misses 2433 2463 +30
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #3647 will not alter performanceComparing Summary
|
…rmash into fix_revindex_signatures
RevIndex.len() and RevIndex.signatures() use picklist, if setRevIndex.len() and RevIndex.signatures() use picklist, if set
|
Ready for review & merge @luizirber @bluegenes ! Note the wasm build is failing. Looks like maybe we need to update maturin? |
…vindex_signatures
|
I'll merge on Sunday or Monday in order to cut a new release. Speak now-ish or hold your peace :) |
ctb
added a commit
that referenced
this pull request
Jun 1, 2025
Minor new features: * add cANI to `sig overlap` (#3644) Bug fixes: * make `RevIndex.len()` and `RevIndex.signatures()` use picklist, if set (#3647) Cleanup and documentation updates: * add rocksdb HOWTO (#3648) Developer updates: * try fixing inline variables in rust `println!` (#3640) Dependabot updates: - Build(deps): Update cachetools requirement from <6,>=4 to >=4,<7 (#3660) - [pre-commit.ci] pre-commit autoupdate (#3659) - Build(deps): Bump criterion from 0.5.1 to 0.6.0 (#3655) - [pre-commit.ci] pre-commit autoupdate (#3654) - Build(deps): Bump tempfile from 3.19.1 to 3.20.0 (#3639) - [pre-commit.ci] pre-commit autoupdate (#3638)
ctb
added a commit
that referenced
this pull request
Jun 2, 2025
This is a patchfix to v4.9.1 (#3665) to deal with a botched source code release. Below are the updates since v4.9.0. Minor new features: * add cANI to `sig overlap` (#3644) Bug fixes: * make `RevIndex.len()` and `RevIndex.signatures()` use picklist, if set (#3647) Cleanup and documentation updates: * add rocksdb HOWTO (#3648) Developer updates: * try fixing inline variables in rust `println!` (#3640) Dependabot updates: - Build(deps): Update cachetools requirement from <6,>=4 to >=4,<7 (#3660) - [pre-commit.ci] pre-commit autoupdate (#3659) - Build(deps): Bump criterion from 0.5.1 to 0.6.0 (#3655) - [pre-commit.ci] pre-commit autoupdate (#3654) - Build(deps): Bump tempfile from 3.19.1 to 3.20.0 (#3639) - [pre-commit.ci] pre-commit autoupdate (#3638)
ctb
added a commit
that referenced
this pull request
Jun 28, 2025
Looks like I forgot to actually release r0.21.0 prior to [release v4.9.2](#3667), which may be causing pyodide compile fail here: pyodide/pyodide-recipes#134 ## [0.21.0] - 2025-06-28 MSRV: 1.74 Changes/additions: * make `RevIndex.len()` and `RevIndex.signatures()` use picklist, if set (#3647) * try fixing inline variables in rust `println!` (#3640) Updates: * Build(deps): Bump cfg-if from 1.0.0 to 1.0.1 (#3689) * Build(deps): Bump roaring from 0.10.12 to 0.11.0 (#3702) * Build(deps): Bump getset from 0.1.5 to 0.1.6 (#3700) * Build(deps): Bump proptest from 1.6.0 to 1.7.0 (#3674) * Build(deps): Bump camino from 1.1.9 to 1.1.10 (#3669) * Build(deps): Bump criterion from 0.5.1 to 0.6.0 (#3655) * Build(deps): Bump tempfile from 3.19.1 to 3.20.0 (#3639)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3645