Adding postgres version check as per issue #43 #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
requested changes
Nov 28, 2017
pkg/postgresql/utils.go
Outdated
| @@ -404,7 +404,7 @@ func getConfigFilePGParameters(ctx context.Context, connParams ConnParams) (comm | |||
|
|
|||
| func ParseBinaryVersion(v string) (int, int, error) { | |||
| // extact version (removing beta*, rc* etc...) | |||
| regex, err := regexp.Compile(`.* \(PostgreSQL\) ([0-9\.]+).*$`) | |||
| regex, err := regexp.Compile(`.* \(PostgreSQL\) ([0-9\.]+).*`) | |||
There was a problem hiding this comment.
The final $ from the regexp is probably unuseful given the .*. Have you removed it also for other reason?
There was a problem hiding this comment.
Yes, it is not useful because .* and the other reason is that when I ran the tests/debugged on a machine with self-compiled postgres I noticed some the regex failed to match when the output to stdout of the version was terminated with '\r\n'...
pkg/postgresql/postgresql.go
Outdated
| @@ -238,6 +238,14 @@ func (p *Manager) Start() error { | |||
| } | |||
|
|
|||
| func (p *Manager) start(args ...string) error { | |||
| log.Infow("checking postgres version") | |||
|
@emdem LGTM. Can you please rebase so I can merge it? |
|
Done! |
|
The tests seem to be intermittently failing due to timeouts... |
|
@emdem tests should work correcly, can you please squash and rebase on current master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.