@dineshba Did an initial review.

In addition you should manage dependencies using go.mod (please use latest go1.11.2) and also vendor them so they could work also with go 1.10 (go mod vendor).

I fetched your PR. Some notes:

• Please use latest go1.11.2 to generate go.mod and go.sum since previous versions had bugs generating the wrong sum.

• Semaphore k8s test is failing because the clusterdata command has changed. These lines:
  

  stolon/scripts/semaphore-k8s.sh

  Line 64 in 2536d50

  OUT=$(./bin/stolonctl --cluster-name kube-stolon --store-backend kubernetes --kube-resource-kind configmap clusterdata | jq .cluster.status.phase)

  
  

  stolon/scripts/semaphore-k8s.sh

  Line 77 in 2536d50

  ./bin/stolonctl --cluster-name kube-stolon --store-backend kubernetes --kube-resource-kind configmap clusterdata | jq .

require an additional read argument.

• The commands doc should be updated to reflect this behavior and the generated doc should be regenerated (calling scripts/gen_commands_doc.sh and committing changes).

• Add a breaking change note to the CHANGELOG.md describing this breaking change in the stolonctl clusterdata command since this will break some current user workflow and needs to be documented.

• Let's add a go generate comments to generate the mocks (see inline comment). So we know which source is mocked and they can be created/updated with a simple go generate ./.... Of course they should be committed like you did, just use go generate and related comments so everyone knows how to generate them. In future a script could be added to automate/test this.