k8s store: use component label instead of app #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d2d963 to
7eafcd7
Compare
Use `component` label instead off `app` label to filter pods. The `app` label is usually used to reflect the entire app (for example see helm label best practices: https://github.com/kubernetes/helm/blob/master/docs/chart_best_practices/labels.md) Fixes sorintlab#466
sgotti
added a commit
that referenced
this pull request
Apr 12, 2018
k8s store: use component label instead of app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
componentlabel instead offapplabel to filter pods.The
applabel is usually used to reflect the entire app (for example seehelm label best practices:
https://github.com/kubernetes/helm/blob/master/docs/chart_best_practices/labels.md)
Fixes #466
/cc @Flowkap @lwolf