-
Notifications
You must be signed in to change notification settings - Fork 446
*: add kubernetes store backend #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c045fd4
to
d8f7674
Compare
8ad6c03
to
f15cec1
Compare
378bd9b
to
455a45b
Compare
This PR adds a new kubernetes store backend. See the related doc in `/doc/architecture.md` and the updated kubernetes example that will use this backend.
455a45b
to
38ae6b1
Compare
*: add kubernetes store backend
Is this due for the next release? |
@Flowkap We'd like to do a release (v0.10.0) next week. This feature is quite new so if you it'll be great if you can help us testing it. I'd like to improve the test suite to also cover all of the current integration tests on kubernetes but it'll take some more time. |
I'd tried to update the stolon chart,but failed due to not connecting sentinels. MAybe you know whats wrong there. lwolf/stolon-chart#18 (comment) I can't find a structural difference between you demo and the deployed chart. I also appended the whole keeper config which seems fine tom me. AS I started with K8 and such a few weeks ago I'm sure I miss something trivial :/ |
Maybe one of you guys can take a look at the above mentione issue? I still can't find an obvious error in the generated config by that chart modification. Still all components do not kick into action as if they can't find the shared configmap. I did a side by side comparison of the chart generated stuff and your example. They look the same for me. |
@Flowkap Do you have problems only with the chart or also with the stolon kubernetes example? If you also have the same problems with the stolon k8s example can you please open a new issue here on stolon since this PR is already merged? |
The example works fine. I tried to add the kubernetes backend options to the chart.ON the issue there I added thorough infos on what I did. I can't find a reason for the behaviour I documented there. I need to admit that Kubernetes and helm are all new to me so it might be a simple thing. :/ |
I found it. Long story short: The app labels MUST be exactly "stolon-keeper" "stolon-proxy" and "stolon-sentinel" ... I'll add a proper PR on the chart later. You should really consider querying by a combination of component label and cluster-name, as a fully qualified app label should be best practise. |
This is already done: https://github.com/sorintlab/stolon/blob/master/pkg/store/k8s.go#L67 If this isn't what you mean please open a new issue. |
This PR adds a new kubernetes store backend.
See the related doc in
/doc/architecture.md
and the updated kubernetes examplethat will use this backend.
TODO