Skip to content

*: add kubernetes store backend #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

sgotti
Copy link
Member

@sgotti sgotti commented Feb 7, 2018

This PR adds a new kubernetes store backend.

See the related doc in /doc/architecture.md and the updated kubernetes example
that will use this backend.

TODO

  • Add some CI tests: it'll take some time to update the test suite to be able run all the current tests inside a k8s cluster (it need to be changed to manage pod resources instead of simple processes, and also retrieve all the logs for debug purposes). So, as a first start, I'll only add tests to deploy a k8s stolon cluster and check that the cluster initializes correctly.

@sgotti sgotti force-pushed the kubernetes_store_backend branch 12 times, most recently from c045fd4 to d8f7674 Compare February 13, 2018 16:02
@sgotti sgotti force-pushed the kubernetes_store_backend branch 3 times, most recently from 8ad6c03 to f15cec1 Compare February 15, 2018 13:06
@sgotti sgotti force-pushed the kubernetes_store_backend branch 2 times, most recently from 378bd9b to 455a45b Compare February 23, 2018 10:48
This PR adds a new kubernetes store backend.

See the related doc in `/doc/architecture.md` and the updated kubernetes example
that will use this backend.
@sgotti sgotti force-pushed the kubernetes_store_backend branch from 455a45b to 38ae6b1 Compare February 23, 2018 12:34
@sgotti sgotti merged commit 38ae6b1 into sorintlab:master Feb 23, 2018
sgotti added a commit that referenced this pull request Feb 23, 2018
@Flowkap
Copy link

Flowkap commented Mar 2, 2018

Is this due for the next release?

@sgotti
Copy link
Member Author

sgotti commented Mar 2, 2018

@Flowkap We'd like to do a release (v0.10.0) next week. This feature is quite new so if you it'll be great if you can help us testing it. I'd like to improve the test suite to also cover all of the current integration tests on kubernetes but it'll take some more time.

@Flowkap
Copy link

Flowkap commented Mar 5, 2018

I'd tried to update the stolon chart,but failed due to not connecting sentinels. MAybe you know whats wrong there.

lwolf/stolon-chart#18 (comment)

I can't find a structural difference between you demo and the deployed chart. I also appended the whole keeper config which seems fine tom me. AS I started with K8 and such a few weeks ago I'm sure I miss something trivial :/

@sgotti sgotti added this to the 0.10.0 milestone Mar 21, 2018
@Flowkap
Copy link

Flowkap commented Mar 27, 2018

Maybe one of you guys can take a look at the above mentione issue? I still can't find an obvious error in the generated config by that chart modification. Still all components do not kick into action as if they can't find the shared configmap. I did a side by side comparison of the chart generated stuff and your example. They look the same for me.

@sgotti
Copy link
Member Author

sgotti commented Mar 27, 2018

@Flowkap Do you have problems only with the chart or also with the stolon kubernetes example? If you also have the same problems with the stolon k8s example can you please open a new issue here on stolon since this PR is already merged?

@Flowkap
Copy link

Flowkap commented Mar 27, 2018

The example works fine. I tried to add the kubernetes backend options to the chart.ON the issue there I added thorough infos on what I did. I can't find a reason for the behaviour I documented there. I need to admit that Kubernetes and helm are all new to me so it might be a simple thing. :/

lwolf/stolon-chart#18

@Flowkap
Copy link

Flowkap commented Mar 29, 2018

I found it. Long story short: The app labels MUST be exactly "stolon-keeper" "stolon-proxy" and "stolon-sentinel" ...
38ae6b1#diff-95cdd374e9440fde010ff35d65f8cf3fR54

I'll add a proper PR on the chart later. You should really consider querying by a combination of component label and cluster-name, as a fully qualified app label should be best practise.

@sgotti
Copy link
Member Author

sgotti commented Mar 29, 2018

You should really consider querying by a combination of component label and cluster-name, as a fully qualified app label should be best practise.

This is already done: https://github.com/sorintlab/stolon/blob/master/pkg/store/k8s.go#L67

If this isn't what you mean please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants