Skip to content

Commit 28f8e61

Browse files
committed
Ensure defaults for booleans is set correctly
Fixes #16
1 parent aa86a34 commit 28f8e61

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ By default, GoTTY starts a web server at port 8080. Open the URL on your web bro
7272
--height value Static height of the screen, 0(default) means dynamically resize (default: 0) [$GOTTY_HEIGHT]
7373
--ws-origin value A regular expression that matches origin URLs to be accepted by WebSocket. No cross origin requests are acceptable by default [$GOTTY_WS_ORIGIN]
7474
--term value Terminal name to use on the browser, one of xterm or hterm. (default: "xterm") [$GOTTY_TERM]
75-
--enable-webgl Enable WebGL renderer (default: false) [$GOTTY_ENABLE_WEBGL]
75+
--enable-webgl Enable WebGL renderer (default: true) [$GOTTY_ENABLE_WEBGL]
7676
--close-signal value Signal sent to the command process when gotty close it (default: SIGHUP) (default: 1) [$GOTTY_CLOSE_SIGNAL]
7777
--close-timeout value Time in seconds to force kill process after client is disconnected (default: -1) (default: -1) [$GOTTY_CLOSE_TIMEOUT]
7878
--config value Config file path (default: "~/.gotty") [$GOTTY_CONFIG]

release-checklist.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
* Check that cross-compilation works.
66
* Ensure NEWS is up-to-date
77
* Ensure contributor list is up-to-date
8-
* Ensure VERSION is set correctly in Makefile
8+
* Ensure usage is correct in Makefile

utils/flags.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,11 @@ func GenerateFlags(options ...interface{}) (flags []cli.Flag, mappings map[strin
4646
})
4747
case reflect.Bool:
4848
flags = append(flags, &cli.BoolFlag{
49-
Name: flagName,
50-
Usage: flagDescription,
51-
EnvVars: []string{envName},
52-
Aliases: aliases,
49+
Name: flagName,
50+
Usage: flagDescription,
51+
EnvVars: []string{envName},
52+
Aliases: aliases,
53+
DefaultText: field.Tag("default"),
5354
})
5455
case reflect.Int:
5556
flags = append(flags, &cli.IntFlag{

0 commit comments

Comments
 (0)